-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'pulled from/into wrong branch' #35
Conversation
Could you remove the lines with the trailing spaces and squash this commit? I'm not sure about the credit line - it's not like this isn't publicly available information in the git man, anyway. What do you think, @k88hudson |
Sorry for the delay @joshdutcher, thanks for doing this. Personally I think this is standard procedure enough to omit the credit line, but I'm open to either way. That said, if larger sections are used or need to be linked to, adding something to a "resources" section makes sense to me. |
I'm totally fine with removing the credit line, and I'll squash the commit. |
some code | ||
>>>>>>> new-commit | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines shouldn't have been edited - the rest looks good. If you can add these back in, we're ready to go.
Sorry about that - got the lines back in there. |
@joshdutcher I did the same thing during a rebase hehe |
Landed! Thanks @joshdutcher |
Thank you. I use git lots at work but this was my first experience contributing to a project on github, so I appreciate the patience and guidance. |
Awesome! Thanks so much for contributing 👍 |
Oh man, welcome! Thanks @joshdutcher |
my text editor automatically trims trailing spaces, so that happened too I guess.