Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'pulled from/into wrong branch' #35

Merged
merged 1 commit into from
Mar 16, 2015
Merged

add 'pulled from/into wrong branch' #35

merged 1 commit into from
Mar 16, 2015

Conversation

joshdutcher
Copy link

my text editor automatically trims trailing spaces, so that happened too I guess.

@RichardLitt
Copy link
Collaborator

Could you remove the lines with the trailing spaces and squash this commit?

I'm not sure about the credit line - it's not like this isn't publicly available information in the git man, anyway. What do you think, @k88hudson

@k88hudson
Copy link
Owner

Sorry for the delay @joshdutcher, thanks for doing this.

Personally I think this is standard procedure enough to omit the credit line, but I'm open to either way.

That said, if larger sections are used or need to be linked to, adding something to a "resources" section makes sense to me.

@joshdutcher
Copy link
Author

I'm totally fine with removing the credit line, and I'll squash the commit.

some code
>>>>>>> new-commit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines shouldn't have been edited - the rest looks good. If you can add these back in, we're ready to go.

@joshdutcher
Copy link
Author

Sorry about that - got the lines back in there.

RichardLitt added a commit to RichardLitt/git-flight-rules that referenced this pull request Mar 16, 2015
@k88hudson
Copy link
Owner

@joshdutcher I did the same thing during a rebase hehe

@RichardLitt RichardLitt merged commit ea87639 into k88hudson:master Mar 16, 2015
@RichardLitt
Copy link
Collaborator

Landed! Thanks @joshdutcher

@joshdutcher
Copy link
Author

Thank you. I use git lots at work but this was my first experience contributing to a project on github, so I appreciate the patience and guidance.

@k88hudson
Copy link
Owner

Awesome! Thanks so much for contributing 👍

@RichardLitt
Copy link
Collaborator

Oh man, welcome! Thanks @joshdutcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants