Added test for TOC to .travis.yml #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
reviewed
Jan 11, 2018
.travis.yml
Outdated
| @@ -3,6 +3,12 @@ rvm: | |||
| - 2.2 | |||
| before_script: | |||
| - gem install awesome_bot | |||
| - npm install doctoc | |||
There was a problem hiding this comment.
Add a package.json file and add doctoc to it, and specify the new dep for anchor-markdown-header there? seems a bit cleaner than using these three commands, but that may just be me...
|
What about a cleanup of node_modules and package-lock.json? Might make sense to either clean them up or add them to the .gitignore and maybe specify a package.json file. |
Runs doctoc for README*.md. If in newly doctoc'ed README*.md there are any diffs against ones commited in git HEAD then the test failes. The script are using the latest anchor-markdown-header from repo to avoid the bug with non-ASCII headers.
buslov
force-pushed
the
add-test-for-toc
branch
from
9930ae1 to
99d3954
Compare
|
@RichardLitt done |
|
Thanks for this. |
aroup
pushed a commit
to aroup/git-flight-rules
that referenced
this pull request
Jan 17, 2020
Runs doctoc for README*.md. If in newly doctoc'ed README*.md there are any diffs against ones commited in git HEAD then the test failes. The script are using the latest anchor-markdown-header from repo to avoid the bug with non-ASCII headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs doctoc for README*.md.
If in newly doctoc'ed README*.md there are any diffs against ones commited in git HEAD then the test failes.
The script are using the latest anchor-markdown-header from repo to avoid the bug with non-ASCII headers.