No dapper, greatly simplified repo build process #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused validate script - Reduce scripts down to entry and package, release/ci/ did the same thing - Replace the Dockerfile.dapper with just the package/Dockerfile. This whole build system was horribly redundant, we don't produce a binary or any go code, we just package a single image in this repo Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
- Use generic docker image, not dapper - Remove use of go env check, package script sets default ARCH Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Jan 15, 2025
cwayne18
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
packagevalidateandentry(the dapper one, not the important one) script were unusedreleaseandcidid the same thing.gotools in this repo. Default ARCH is defined already inpackageDockerdocker image instead of dapperTLDR
This repo has a Dockerfile that embeds the
entryscript in the resulting klipper-helm image. Drone pipelines build and publish that one image in multiple ARCH.