Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k3s root to v0.12.0 and remove strongswan binaries #6400

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

brandond
Copy link
Member

@brandond brandond commented Nov 2, 2022

Proposed Changes

Bump k3s-root and remove embedded strongswan support. This saves 2124 kB of space from the K3s binary.

before/after K3s binary size comparison:

k3s binary dist/artifacts/k3s size 67129344 is less than max acceptable size of 73400320 bytes (70 MiB)
k3s binary dist/artifacts/k3s size 64954368 is less than max acceptable size of 73400320 bytes (70 MiB)

Types of Changes

version bump

Verification

  • Configure a cluster (1 or more nodes) using --flannel-backend=ipsec
  • Upgrade the cluster without installing strongswan on the host: note that k3s fails to start
  • Upgrade the cluster after installing strongwan packages on the host: note that k3s continues to work as usual

Testing

Linked Issues

User-Facing Change

The embedded k3s-root version has been bumped to v0.12.0, based on buildroot 2022.08.1.
The embedded swanctl and charon binaries have been removed. If you are using the ipsec flannel backend, please ensure that the strongswan `swanctl` and `charon` packages are installed on your node before upgrading k3s.

Further Comments

@brandond brandond requested a review from a team as a code owner November 2, 2022 00:12
@brandond brandond changed the title Bump k3s root Bump k3s root to v0.12.0 and remove strongswan binaries Nov 2, 2022
@cwayne18
Copy link
Member

cwayne18 commented Nov 2, 2022

Please don't merge this until we get signoff from William

@brandond brandond marked this pull request as draft November 2, 2022 00:24
@brandond brandond force-pushed the bump-k3s-root branch 2 times, most recently from ce357c8 to 7c60196 Compare November 22, 2022 21:48
@brandond brandond marked this pull request as ready for review November 22, 2022 23:13
@brandond
Copy link
Member Author

@cwayne18 just to confirm, we have sign-off on this correct? As long as we document the change?

@brandond
Copy link
Member Author

Confirmed via Slack

@cwayne18
Copy link
Member

Im fine with this landing, but we just need to make sure the release notes and docs include instructions for getting their own ipsec running

Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMIO

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Copy link
Member Author

brandond commented Dec 1, 2022

s390x flaked due to an issue with rdma cgroups not getting cleaned up on the CI node. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants