Add systemd cgroup controller support #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
approved these changes
Apr 19, 2022
dereknola
reviewed
Apr 19, 2022
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
systemd_cgroup_driver
branch
from
ee6385f
to
7fc2c3f
Compare
|
yeah, overeager refactoring. Fixed now. |
briandowns
approved these changes
Apr 19, 2022
This was referenced May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use the systemd cgroup controller when possible. This controller has been recommended over the legacy cgroupfs driver for several releases.
Types of Changes
enhancement
Verification
See linked issue
Linked Issues
User-Facing Change
Further Comments
According to the runc documentation, systemd 244 or newer adds support for cpuset cgroup delegation, so delegation of this group is what we gate use of the systemd cgroup driver on. Plus presence of the NOTIFY_SOCKET to indicate operation under systemd, of course.
https://github.com/opencontainers/runc/blob/main/docs/cgroup-v2.md#systemd