-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import containerd images with all platforms #2198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI I have confirmed that importing with all platforms fixes arm64 with the images in the current airgap tarball. You can even fix this manually with
|
brandond
force-pushed
the
import-all-platforms
branch
from
September 15, 2020 00:23
e5bd4a0
to
07b8629
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
import-all-platforms
branch
from
September 15, 2020 00:29
07b8629
to
d7e3bef
Compare
cjellick
approved these changes
Sep 15, 2020
brandond
changed the title
WIP- Import containerd images with all platforms
Import containerd images with all platforms
Sep 15, 2020
brandond
approved these changes
Sep 15, 2020
Confirmed with PR build on arm64:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Set WithAllPlatforms option on containerd image import.
Types of Changes
Verification
k3s ctr images check
; verify all image layers presentk3s kubectl get pods -A
; verify all pods running or completedLinked Issues
Related to #1285
Further Comments
Some of the images contain configs that indicate they are amd64 despite actually being arm64. This causes the containerd import process to skip their layers since it filters out mismatched architectures by default. Setting the option to import layers for all platforms allows us to use these images anyways, until the upstreams are fixed.