Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.28] Simplify svclb ds #11085

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

manuelbuil
Copy link
Contributor

Backport: #10954
Issue: #11082

Signed-off-by: manuelbuil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner October 11, 2024 09:29
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.35%. Comparing base (3cc4334) to head (4535b20).
Report is 2 commits behind head on release-1.28.

Files with missing lines Patch % Lines
pkg/cloudprovider/servicelb.go 71.42% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (3cc4334) and HEAD (4535b20). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (3cc4334) HEAD (4535b20)
unittests 1 0
inttests 3 0
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.28   #11085       +/-   ##
=================================================
- Coverage         43.14%   27.35%   -15.80%     
=================================================
  Files               179      162       -17     
  Lines             18601    14232     -4369     
=================================================
- Hits               8026     3893     -4133     
- Misses             9266     9604      +338     
+ Partials           1309      735      -574     
Flag Coverage Δ
e2etests 27.35% <71.42%> (-18.21%) ⬇️
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit 571f20a into k3s-io:release-1.28 Oct 12, 2024
31 checks passed
@manuelbuil manuelbuil deleted the svclb128 branch October 12, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants