Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Launch private registry with init #11045

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #10822

Types of Changes

Verification

Testing

Linked Issues

#10821

User-Facing Change


Further Comments

…leanup (k3s-io#10822)

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner October 9, 2024 21:17
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.02%. Comparing base (eac26ef) to head (05cba40).
Report is 2 commits behind head on release-1.28.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #11045      +/-   ##
================================================
- Coverage         40.87%   36.02%   -4.85%     
================================================
  Files               179      162      -17     
  Lines             18567    14269    -4298     
================================================
- Hits               7589     5141    -2448     
+ Misses             9695     8125    -1570     
+ Partials           1283     1003     -280     
Flag Coverage Δ
e2etests 36.02% <ø> (-9.85%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 3999f83 into k3s-io:release-1.28 Oct 10, 2024
29 checks passed
@dereknola dereknola deleted the priv_reg_128 branch October 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants