Use static CNI bin dir #10868
Merged
Use static CNI bin dir #10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
stable-cni-bin
branch
2 times, most recently
from
ccdbb65
to
959c7e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10868 +/- ##
==========================================
- Coverage 49.69% 44.07% -5.62%
==========================================
Files 178 178
Lines 14801 14801
==========================================
- Hits 7355 6524 -831
- Misses 6101 7074 +973
+ Partials 1345 1203 -142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Maintain a separate dir for CNI binaries so that additional plugins can be installed in a predictable location that does not change every time k3s is upgraded. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
stable-cni-bin
branch
from
959c7e1
to
0ad1bac
Compare
galal-hussein
approved these changes
Sep 20, 2024
dereknola
approved these changes
Sep 23, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Maintain a separate dir for CNI binaries so that additional plugins can be installed in a predictable location that does not change every time k3s is upgraded.
Types of Changes
enhancement
Verification
/var/lib/rancher/k3s/data/cni/var/lib/rancher/k3s/data/cniis now used ascni_bindir in/var/lib/rancher/k3s/agent/etc/containerd/config.tomlTesting
See above
Linked Issues
User-Facing Change
Further Comments