Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual upgrade page with better order of operations #251

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Mar 14, 2024

Addresses: #178

Mentions that you have to stop the existing K3s service before running the installation script with a new version.

Signed-off-by: Derek Nola <derek.nola@suse.com>
@brandond
Copy link
Member

have to stop the existing K3s service before running the installation script with a new version

Do you though? I thought that the install script would restart the service for you if the config or version changed.

@dereknola
Copy link
Member Author

Ah I guess your right. My brain was just on autopilot when looking at the install script output:

[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s

We weirdly don't have output that the old k3s service was stopped.

@brandond
Copy link
Member

brandond commented Mar 14, 2024

It's because we just log that we start it when actually we restart it. Which is either a start or a stop/start depending on current state.
https://github.com/k3s-io/k3s/blob/bba3e3c66b22bbf112dc316a9b5dbd27f68f4ba8/install.sh#L1042-L1045

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
docs/upgrades/manual.md Outdated Show resolved Hide resolved
Co-authored-by: Brad Davidson <brad@oatmail.org>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola mentioned this pull request Mar 19, 2024
@dereknola dereknola merged commit d051e9a into k3s-io:main Mar 20, 2024
3 checks passed
@dereknola dereknola deleted the upgrade_nits branch March 20, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants