feat: allow service monitor without authentication or with auth data from existing secret #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnitze
force-pushed
the
feat/allow-service-monitor-without-or-with-custom-authentication
branch
2 times, most recently
from
06ec3fe to
4f06e99
Compare
…from existing secret
maxnitze
force-pushed
the
feat/allow-service-monitor-without-or-with-custom-authentication
branch
from
4f06e99 to
cf9da31
Compare
k3rnelpan1c-dev
added
documentation
|
Hey, sorry for the late response, been rather busy IRL lately and haven't had the time nor motivation to really give this project the attention it deserves. |
|
Hey! I answered your comment. I can switch it, of course. Makes more sense to me as well. Your call :) |
…ustom-authentication
|
Thank you for your contribution! |
maxnitze
deleted the
feat/allow-service-monitor-without-or-with-custom-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to disable authentication of the service monitor by settings
.Values.serviceAccount.authentication.enabled=false. Also allow to provide an existing secret for the service monitor authentication.