config: fix failing v1alpha2 -> v1alpha3 migration #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add validation as extra step after migration - add missing json struct tags to new v1alpha3 config fields
…mpty config fields
…on with schema validation
iwilltry42
force-pushed
the
fix/break-on-empty-config-field
branch
from
3262e99
to
c77598e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omitemptytags to configs to avoid (un-)marshalling issuesstringtype fortime.Durationtype field in JSON Schema (doesn't work properly sometimes due to broken handling of time.Duration as per all: decide what can implement TextMarshaler/TextUnmarshaler golang/go#10275)fixes #790