Skip to content

[Enhancement] Do not print the /etc/hosts message if the registry name can be resolved - #177

Merged
iwilltry42 merged 1 commit into
k3d-io:masterfrom
inercia:inercia/registries_skip_warning
Jan 27, 2020
Merged

[Enhancement] Do not print the /etc/hosts message if the registry name can be resolved#177
iwilltry42 merged 1 commit into
k3d-io:masterfrom
inercia:inercia/registries_skip_warning

Conversation

@inercia

@inercia inercia commented Jan 26, 2020

Copy link
Copy Markdown
Collaborator

We are always printing the Make sure you have an alias in your /etc/hosts file like '127.0.0.1 registry.local message, even if registry.local can already be resolved. This skips that message when the name registry.local can be resolved (in a really short amount of time).

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
@iwilltry42 iwilltry42 changed the title Do not print the /etc/hosts message if the registra name can be resolved [Enhancement] Do not print the /etc/hosts message if the registry name can be resolved Jan 27, 2020
@iwilltry42 iwilltry42 self-assigned this Jan 27, 2020
@iwilltry42 iwilltry42 added the enhancement New feature or request label Jan 27, 2020

@iwilltry42 iwilltry42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwilltry42
iwilltry42 merged commit c2aeeca into k3d-io:master Jan 27, 2020
@inercia
inercia deleted the inercia/registries_skip_warning branch March 30, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants