Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook following icefall convention #72

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Add pre-commit hook following icefall convention #72

merged 3 commits into from
Jul 22, 2022

Conversation

ezerhouni
Copy link
Collaborator

No description provided.

@ezerhouni ezerhouni requested a review from csukuangfj July 21, 2022 14:12
@ezerhouni
Copy link
Collaborator Author

@csukuangfj It is highly inspired by icefall

@csukuangfj
Copy link
Collaborator

Thanks!

Could you also use
https://github.com/k2-fsa/icefall/blob/master/.github/workflows/style_check.yml
to let the CI check the Python code style?

@ezerhouni
Copy link
Collaborator Author

I will work on the 2 PR first thing tomorrow morning

@csukuangfj
Copy link
Collaborator

Thanks!

@ezerhouni
Copy link
Collaborator Author

@csukuangfj Just added the file, is there something else to add to the CI ?

@csukuangfj
Copy link
Collaborator

Thanks! Merging.

@csukuangfj csukuangfj merged commit 85ad46e into k2-fsa:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezerhouni @csukuangfj