-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming asr time stamp #146
Conversation
@csukuangfj I have this issue when installing :
Did you have the fix somewhere or should I take care of it ? (I saw that you made the code) |
I see. The master code: sherpa/sherpa/csrc/online_asr.cc Lines 246 to 247 in b163428
Code of this PR sherpa/sherpa/csrc/rnnt_beam_search.cc Lines 205 to 211 in 8990519
This PR changes the signature of |
online_asr.cc was added after #119 is created. Please change online_asr.cc accordingly. For now, just pass an empty vector to |
@csukuangfj FYI, there is also |
@csukuangfj Can you have a look ? I think the cpp is broken though, I will try to have a look today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thanks for the help.
It is just a dummy implementation for the OnlineAsr, but I compiles, I think. What do you mean |
@csukuangfj For the |
The timestamp won't be correct, but it won't affect the recognition results. Since we are not returning the timestamp information in c++, the current dummy implementation should be fine. We can fix it in a separate PR to also return timestamp in c++. |
@ezerhouni |
Copy from : #119