Fix dither binding in Pybind11 to ensure independence from high_freq in FeatureExtractorConfig
#1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eq` in `FeatureExtractorConfig`
csukuangfj
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect binding of the dither attribute in the FeatureExtractorConfig Pybind11 bindings. Previously, dither was mistakenly bound to the high_freq member variable, causing unexpected behavior where changes to one attribute affected the other.
The fix updates the Pybind11 binding to correctly map dither to its own member variable, ensuring that dither and high_freq are independent properties in Python