Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove T>=S assertion for regular transducer loss #25

Closed
wants to merge 2 commits into from

Conversation

desh2608
Copy link

@desh2608 desh2608 commented May 1, 2023

See #20

@pkufool
Copy link
Contributor

pkufool commented Jul 19, 2023

@desh2608 Sorry, I did not notice this PR, I think if we remove T >= S assertion for regular transducer, we have to add another assert to make sure prune_range is large enough. For example, T == 2, range == 3 and S ==10, it can not cover all the S with 2 steps by range==3, and then result to a inf loss value.

[edit:] I saw we alreay merged this change to k2 (k2-fsa/k2#1149), remember to revert it if this is really a problem. This should be rare cases, I think in icefall we will filter inf in train.py.

@danpovey
Copy link
Collaborator

ah Ok @pkufool ... perhaps we can say that prune_range is advisory, and it will print a warning and increase prune_range if there is that type of problem? I think that is less likely to be disruptive.

@pkufool
Copy link
Contributor

pkufool commented Aug 24, 2023

Closed by #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants