Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installflags change detection #784

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

kke
Copy link
Contributor

@kke kke commented Nov 5, 2024

Fixes #779

There was plenty of problems in the existing implementation:

  • Incorrectly parsed the kubelet extra args value because the regexp cut it at the first space
  • Omitted "--" in the parsed flags (because of the regexp)
  • Inconsistent quoting/unquoting/splitting

Fixed by importing a couple of functions from rig v2 and getting rid of the regexp altogether.

@kke kke added the bug Something isn't working label Nov 5, 2024
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke force-pushed the fix-installflags-change-detection branch from 938f802 to b4634ad Compare November 5, 2024 11:33
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke merged commit fa88107 into main Nov 6, 2024
39 checks passed
@kke kke deleted the fix-installflags-change-detection branch November 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate kubelet extra args produced by installFlags change detection
1 participant