Unify Airgap and IPv6 test image build workflows #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that need to be resolved. |
1 task
twz123
force-pushed
the
ipv6-test-images
branch
from
66acf2c to
abd3693
Compare
|
This pull request has merge conflicts that need to be resolved. |
Concatenate the names directly in the Makefile. This saves a lot of complexity in the gen-test-images-list program. Add some missing requisites to the IPv6 test image bundle targets. Since the container images are kept in the Makefile itself, Renovate needs to have an eye on it, too. Add the appropriate glob patterns to its config. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
This is a preliminary step to refactor the airgap image bundle and the IPv6 test image bundle workflow into a single one. So that git will notice the file rename. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Rename all the IPv6 test image bundle files to consistently use the "ipv6-test" prefix, so their naming aligns with the one used by the airgap image bundle. That way, all the usages of "airgap" can be replaced with the newly introduced "image-bundle-name" variable, and both bundles can share the same workflow. This fixes a bug related to bad image bundle caches for the IPv6 test image bundles. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
ipv6-test-images
branch
from
abd3693 to
042170e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename all the IPv6 test image bundle files to consistently use the "ipv6-test" prefix, so their naming aligns with the one used by the airgap image bundle. That way, all the usages of "airgap" can be replaced with the newly introduced "image-bundle-name" variable, and both bundles can share the same workflow.
This fixes a bug related to bad image bundle caches for the IPv6 test image bundles.
Simplify IPv6 image list generation by concatenating the names directly in the Makefile. This saves a lot of complexity in the gen-test-images-list program. Add some missing requisites to the IPv6 test image bundle targets. Since the container images are kept in the Makefile itself, Renovate needs to have an eye on it, too. Add the appropriate glob patterns to its config.
Type of change
How Has This Been Tested?
Checklist