fix(helm): error gets removed from chart cr on subsequent reconciles

Signed-off-by: Ethan Mosbaugh <ethan@replicated.com>
k0sproject · Aug 15, 2024 · 6fef437 · 6fef437
1 parent 761867a
commit 6fef437
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/pkg/component/controller/extensions_controller.go b/pkg/component/controller/extensions_controller.go
@@ -291,19 +291,20 @@ func (cr *ChartReconciler) updateOrInstallChart(ctx context.Context, chart helmv
 			return fmt.Errorf("can't reconcile installation for %q: %w", chart.GetName(), err)
 		}
 	} else {
-		if cr.chartNeedsUpgrade(chart) {
-			// update
-			chartRelease, err = cr.helm.UpgradeChart(ctx,
-				chart.Spec.ChartName,
-				chart.Spec.Version,
-				chart.Status.ReleaseName,
-				chart.Status.Namespace,
-				chart.Spec.YamlValues(),
-				timeout,
-			)
-			if err != nil {
-				return fmt.Errorf("can't reconcile upgrade for %q: %w", chart.GetName(), err)
-			}
+		if !cr.chartNeedsUpgrade(chart) {
+			return nil
+		}
+		// update
+		chartRelease, err = cr.helm.UpgradeChart(ctx,
+			chart.Spec.ChartName,
+			chart.Spec.Version,
+			chart.Status.ReleaseName,
+			chart.Status.Namespace,
+			chart.Spec.YamlValues(),
+			timeout,
+		)
+		if err != nil {
+			return fmt.Errorf("can't reconcile upgrade for %q: %w", chart.GetName(), err)
 		}
 	}
 	if err := apiretry.RetryOnConflict(apiretry.DefaultRetry, func() error {