Skip to content

Commit

Permalink
Merge pull request #4421 from twz123/kine-metrics-port
Browse files Browse the repository at this point in the history
Change kine metrics port from 8080 to 2380
  • Loading branch information
twz123 authored May 16, 2024
2 parents 9d3aa03 + 179989e commit 4141997
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions pkg/component/controller/kine.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ func (k *Kine) Start(ctx context.Context) error {
// invalid URLs that are understood by kine.
// https://github.com/k3s-io/kine/blob/v0.10.1/pkg/endpoint/endpoint.go#L277-L285
fmt.Sprintf("--listen-address=unix://%s", k.K0sVars.KineSocketPath),
// Enable metrics on port 2380. The default is 8080, which clashes with kube-router.
"--metrics-bind-address=:2380",
},
UID: k.uid,
GID: k.gid,
Expand Down
2 changes: 1 addition & 1 deletion pkg/component/controller/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func (m *Metrics) newKineJob() (*job, error) {

return &job{
log: m.log.WithField("metrics_job", "kine"),
scrapeURL: "http://localhost:8080/metrics",
scrapeURL: "http://localhost:2380/metrics",
name: "kine",
hostname: m.hostname,
scrapeClient: httpClient,
Expand Down

0 comments on commit 4141997

Please sign in to comment.