scaffolding: change default cloudName on dependency test#692
Open
winiciusallan wants to merge 1 commit intok-orc:mainfrom
Open
scaffolding: change default cloudName on dependency test#692winiciusallan wants to merge 1 commit intok-orc:mainfrom
winiciusallan wants to merge 1 commit intok-orc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaffolding tool is generating the import-dependency test using admin credentials for the resource that will be created. We avoid using admin credentials whenever it is not needed, so I believe it is better to generate a less privileged cloudName and let the user change it if needed.