Merged
Conversation
Member
|
All those changes in the API interfaces: are there to comply with the new libraries? Did you do that by hand, or is it the result of a script? |
Collaborator
Author
They're the result of |
Collaborator
Author
|
go-apidiff flagged the following breaking change: I believe this is only for test ( |
Now that we've switched to go 1.24, we should drop the version pinning.
Collaborator
Author
|
I had to re-generate files after we merged the Domain controller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump k8s libs to v0.34 and controller-runtime to v0.22.4.
Also removed upper version pin for gomega and text libs now that we're on go 1.24.