feat: 2025-may post upgrade changes#55
Merged
fpelliccioni merged 1 commit intomasterfrom Jun 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the endian utility after the May 2025 upgrade, adding C++23 support for byte swapping and a dedicated conversion function.
- Added
<bit>include forstd::byteswap - Introduced
to_big_endian_int(uint32_t)for native little-endian conversion
Comments suppressed due to low confidence (2)
include/kth/infrastructure/utility/endian.hpp:47
- [nitpick] The name
to_big_endian_intdiffers from the existingto_big_endiantemplate. Consider adding auint32_tspecialization or renaming to align with the template API.
uint32_t to_big_endian_int(uint32_t value) {
include/kth/infrastructure/utility/endian.hpp:46
- [nitpick] Add a brief Doxygen comment explaining the behavior and intended use of
to_big_endian_int, including that it only covers 32-bit values.
constexpr uint32_t to_big_endian_int(uint32_t value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.