Add Go SAIS suffix sorter #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx calculations were casting c1 to uint, when it should be byte (so additions overflow) in length_8_32
Verified jitted generic CQ is equivalent to length_8_32 and length_32 output (the ones without typeof branches)
Move trivial cases to Sort and out of sais_32 Don't allocate tmp cleared, since we clear freq/bucket explicitly
Also add a sized random buffer test set. This isn't a good corprus for real world performance, but it helps to identify constant runtime costs that determine when we should upgrade the algorithm as the size of input increases.
|
This also bumps DQ.SS.SAIS version to v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.