Skip to content

Conversation

Stewori
Copy link
Member

@Stewori Stewori commented Jun 7, 2020

No description provided.

Copy link
Contributor

@adamburkegh adamburkegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@jamesmudd jamesmudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@Stewori
Copy link
Member Author

Stewori commented Jun 8, 2020

The additional nesting level might not be supported. So far I wasn't able to set up jekyll locally to test this. This is a hassle because my system ruby is too old...

@adamburkegh
Copy link
Contributor

I just gave it a quick test locally with this patch, and the stuff under the new Legacy submenu didn't actually work. It just got a Legacy entry with an empty anchor and no sub items. So hold off merging I guess. The other changes behaved themselves.

@Stewori
Copy link
Member Author

Stewori commented Jun 8, 2020

I will create a page similar to links, holding the legacy links.

@Stewori
Copy link
Member Author

Stewori commented Jun 8, 2020

This should be workable now and I finally managed to test it locally. We can leave it pending for a while until @jeff5 confirms that the jython/jython repo is sound.

@jeff5
Copy link
Member

jeff5 commented Jun 10, 2020

Thanks for catching this necessary change to the website. I haven't succeeded in testing the website on my own machine (tool installation problems), so I'm not able to review. Changes I made myself were very conservative (non-structural).

... We can leave it pending for a while until @jeff5 confirms that the jython/jython repo is sound.

I've done what I can think of and was hoping someone else would find what I've missed (and hoping that's nothing significant).

@Stewori
Copy link
Member Author

Stewori commented Jun 14, 2020

To me, this sounds like we can merge it now. It occurred to me that the new Legacy-dev page might look better with some slight descriptions of the links but I think it's good for now. We can polish it at any time if we decide to.

@Stewori Stewori merged commit 487eae0 into jython:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants