-
Notifications
You must be signed in to change notification settings - Fork 6
Updated links to reflect move to github. #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good
The additional nesting level might not be supported. So far I wasn't able to set up jekyll locally to test this. This is a hassle because my system ruby is too old... |
I just gave it a quick test locally with this patch, and the stuff under the new Legacy submenu didn't actually work. It just got a Legacy entry with an empty anchor and no sub items. So hold off merging I guess. The other changes behaved themselves. |
I will create a page similar to links, holding the legacy links. |
This should be workable now and I finally managed to test it locally. We can leave it pending for a while until @jeff5 confirms that the jython/jython repo is sound. |
Thanks for catching this necessary change to the website. I haven't succeeded in testing the website on my own machine (tool installation problems), so I'm not able to review. Changes I made myself were very conservative (non-structural).
I've done what I can think of and was hoping someone else would find what I've missed (and hoping that's nothing significant). |
To me, this sounds like we can merge it now. It occurred to me that the new Legacy-dev page might look better with some slight descriptions of the links but I think it's good for now. We can polish it at any time if we decide to. |
No description provided.