Fixes to build on pytorch master and python 3.7 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dereferencing pointer to incomplete type ‘THTensor {aka struct
THTensor}’` error is fixed in the roi_crop layer. The pointer
references are changed to functions.
The `dereferencing pointer to incomplete type ‘THTensor {aka struct
THTensor}’` error is fixed in the nms_cuda layer. The pointer
references are changed to functions.
jwyang
approved these changes
Aug 29, 2018
jwyang
approved these changes
Aug 29, 2018
jwyang
approved these changes
Aug 29, 2018
usherbob
pushed a commit
to usherbob/faster-rcnn.pytorch
that referenced
this pull request
Nov 11, 2018
Fixes to build on pytorch master and python 3.7
|
@jwyang @ahmed-shariff First of all, thank you for your work and it's great to see this fix for the Python version.But I have a question. Which version of Torch should I use when I'm using Python 3.7?Because I noticed that Torch 0.4.0 was not supported in Python 3.7, I really hope to get your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Successfully ran make.sh on my pc
specs:
Arch linux
GTX 1050
cuda 9.1
cudnn 7.1
gcc 5.4.1
pytorch build: f126687fbca9414696c930a67f7cf1bded29804c