Bugfix - Raise Descriptive Error for hmac_secret empty and OpenSSL 3.0 Issue #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmchan
force-pushed
the
bugfix/blank-hmac-secrets
branch
from
e0a035a to
8819fd1
Compare
anakinj
reviewed
Oct 24, 2022
README.md
Outdated
| @@ -77,7 +77,7 @@ puts decoded_token | |||
| * HS512 - HMAC using SHA-512 hash algorithm | |||
|
|
|||
| ```ruby | |||
| # The secret must be a string. A JWT::DecodeError will be raised if it isn't provided. | |||
| # The secret must be a string. With OpenSSL 3.0, JWT::DecodeError will be raised if it isn't provided. | |||
There was a problem hiding this comment.
It's the combination of OpenSSL 3.0 and the openssl gem prior to 3.0.1. So this comment will become less significant when time moves forward.
jonmchan
force-pushed
the
bugfix/blank-hmac-secrets
branch
from
8819fd1 to
6382ac7
Compare
|
Looks great @jonmchan. Today I also learned about about the Could I still bother you be so kind and add a little something into the CHANGELOG.md related to this change? |
anakinj
approved these changes
Oct 24, 2022
|
Thank you for your effort on this. Highly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526.
Changes error when utilizing empty
hmac_secretfrom cryptic:to clearer error: