Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore casing of algorithm #405

Merged
merged 13 commits into from
Feb 9, 2021
Merged

Ignore casing of algorithm #405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a196b81
Ignore casing of algorithm. Preserve original casing during encode/de…
johnnyshields Feb 4, 2021
135b002
Fix indentation as per auto-code review
johnnyshields Feb 4, 2021
99bb1b9
Case insensitivity v2: coerce algo to correct casing
johnnyshields Feb 5, 2021
58f39a7
Fixes to case insensitivity
johnnyshields Feb 6, 2021
0d2199c
Freeze constants
johnnyshields Feb 6, 2021
4908379
Fix auto-code review
johnnyshields Feb 6, 2021
a332b5e
Minor cleanup
johnnyshields Feb 6, 2021
ec59733
Fix code climate review
johnnyshields Feb 6, 2021
6387bc1
Whitelist extend self for algos.rb
johnnyshields Feb 6, 2021
4b2ccd8
casecmp? is only in Ruby 2.5 and greater
johnnyshields Feb 6, 2021
0647ffd
Fix rubocop
johnnyshields Feb 7, 2021
6300a32
Respond to comments
johnnyshields Feb 8, 2021
53101a8
Revert casing of ED25519
johnnyshields Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert casing of ED25519
  • Loading branch information
@johnnyshields
johnnyshields committed Feb 8, 2021
commit 53101a8da17b4b939a31ec3326a03c26ab369365
2 changes: 1 addition & 1 deletion lib/jwt/algos/eddsa.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module Algos
module Eddsa
module_function

SUPPORTED = %w[Ed25519].freeze
SUPPORTED = %w[ED25519].freeze

def sign(to_sign)
algorithm, msg, key = to_sign.values
Expand Down
6 changes: 3 additions & 3 deletions spec/jwt_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@

if defined?(RbNaCl)
data.merge!(
'Ed25519_private' => RbNaCl::Signatures::Ed25519::SigningKey.new('abcdefghijklmnopqrstuvwxyzABCDEF'),
'Ed25519_public' => RbNaCl::Signatures::Ed25519::SigningKey.new('abcdefghijklmnopqrstuvwxyzABCDEF').verify_key,
'ED25519_private' => RbNaCl::Signatures::Ed25519::SigningKey.new('abcdefghijklmnopqrstuvwxyzABCDEF'),
'ED25519_public' => RbNaCl::Signatures::Ed25519::SigningKey.new('abcdefghijklmnopqrstuvwxyzABCDEF').verify_key,
)
end
data
Expand Down Expand Up @@ -190,7 +190,7 @@
end

if defined?(RbNaCl)
%w[Ed25519].each do |alg|
%w[ED25519].each do |alg|
context "alg: #{alg}" do
before(:each) do
data[alg] = JWT.encode payload, data["#{alg}_private"], alg
Expand Down