Makefile: move 'EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)' at the end of E… #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XTRA_FLAGS assignment At the moment USER_EXTRA_CFLAGS can't override local Makfile EXTRA_CFLAGS since it's assigned at the beginning of the Makefile. For example it's not possible to undefine the hardcoded CONFIG_LITTLE_ENDIAN and this doesn't allow to build these modules for big endian architectures. So let's move the assignment of USER_EXTRA_CFLAGS to EXTRA_CFLAGS after the last EXTRA_CFLAGS assignment. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
|
Can this patch be applied? Thanks in advance! |
|
Sorry, I miss this PR! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…XTRA_FLAGS assignment
At the moment USER_EXTRA_CFLAGS can't override local Makfile EXTRA_CFLAGS since it's assigned at the beginning of the Makefile. For example it's not possible to undefine the hardcoded CONFIG_LITTLE_ENDIAN and this doesn't allow to build these modules for big endian architectures. So let's move the assignment of USER_EXTRA_CFLAGS to EXTRA_CFLAGS after the last EXTRA_CFLAGS assignment.