-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat / Featured shelf cosmetic update #628
base: develop
Are you sure you want to change the base?
Conversation
refactor(home): more code splitting
feat(home): make featured pagination acessible
refactor(home): minor improvements refactor(home): code optimisations refactor(home): minor style improvements
5b1b076
to
77582c4
Compare
Really nice improvement! I detected one visual problem; when you use the pagination dots, they move. So i need to reposition my mouse cursor anytime I want to click the dots. Other points to consider:
|
@@ -27,5 +28,6 @@ | |||
"slide_next": "Next slide", | |||
"slide_previous": "Previous slide", | |||
"slide_right": "Slide right", | |||
"slide_to": "Slide to page {{page}} of {{pages}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor; I would go with "Slide to item x of y" or "Go to item x of y". When we wrap it in an <ul>
, the "x of y" part is not needed in my eyes.
I think we should only use "pages" if there are more items per slide.
Using "pages" as a metaphor, could give the assumption a page can consist of multiple items. Such as
refactor(home): improve scroll/swipe locking refactor(home): improve swipe area and target refactor(home): fix pagination not always clickable refactor(home): reposition chevrons and later fade out mobile refactor(home): allow 2 lines title refactor(home): copy update refactor(home): use nav and li for pagination
…-web-app into feat/featured-shelf-update
Feat / Featured shelf cosmetic update
This PR improves the look and feel of the featured shelf.
Steps completed:
According to our definition of done, I have completed the following steps: