Feat / Featured shelf cosmetic update #628
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(home): more code splitting
feat(home): make featured pagination acessible
refactor(home): minor improvements refactor(home): code optimisations refactor(home): minor style improvements
royschut
force-pushed
the
feat/featured-shelf-update
branch
from
5b1b076
to
77582c4
Compare
|
Really nice improvement! I detected one visual problem; when you use the pagination dots, they move. So i need to reposition my mouse cursor anytime I want to click the dots. Other points to consider:
|
langemike
reviewed
Oct 24, 2024
| @@ -27,5 +28,6 @@ | |||
| "slide_next": "Next slide", | |||
| "slide_previous": "Previous slide", | |||
| "slide_right": "Slide right", | |||
| "slide_to": "Slide to page {{page}} of {{pages}}", | |||
There was a problem hiding this comment.
Minor; I would go with "Slide to item x of y" or "Go to item x of y". When we wrap it in an <ul>, the "x of y" part is not needed in my eyes.
I think we should only use "pages" if there are more items per slide.
Using "pages" as a metaphor, could give the assumption a page can consist of multiple items. Such as
refactor(home): improve scroll/swipe locking refactor(home): improve swipe area and target refactor(home): fix pagination not always clickable refactor(home): reposition chevrons and later fade out mobile refactor(home): allow 2 lines title refactor(home): copy update refactor(home): use nav and li for pagination
…-web-app into feat/featured-shelf-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat / Featured shelf cosmetic update
This PR improves the look and feel of the featured shelf.
Steps completed:
According to our definition of done, I have completed the following steps: