Fix / demo config reset #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
reviewed
Sep 11, 2024
platforms/web/src/components/DemoConfigDialog/DemoConfigDialog.tsx
Outdated
Show resolved
Hide resolved
langemike
approved these changes
Sep 11, 2024
AntonLantukh
approved these changes
Sep 11, 2024
refactor(project): remove unnecessary form target refactor(project): update snapshot
royschut
force-pushed
the
fix/demo-config-source-reset
branch
from
9fb0095
to
d87708a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the "Unselect this config" button in demo mode, which was not responding. This happened because
useTrackConfigKeyChangekeeps undoing the change. Hard-setting thewindow.location.hreffixes it, much like we do in all other config switch navigations. I have also removed some code that became obsolete.Steps completed:
According to our definition of done, I have completed the following steps: