Feat / log service #539
Merged
Feat / log service #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
langemike,
dbudzins,
AntonLantukh,
MelissaDTH and
royschut
|
Visit the preview URL for this PR (updated for commit 35303c8): https://ottwebapp--pr539-feat-log-service-t1xogqkd.web.app (expires Sat, 03 Aug 2024 13:39:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
royschut
approved these changes
Jun 3, 2024
langemike
approved these changes
Jun 3, 2024
ChristiaanScheermeijer
added
the
JWP Audit
dbudzins
reviewed
Jun 4, 2024
packages/common/src/services/integrations/cleeng/CleengService.ts
Outdated
Show resolved
Hide resolved
packages/common/src/services/logging/transporters/ConsoleTransporter.ts
Outdated
Show resolved
Hide resolved
ChristiaanScheermeijer
force-pushed
the
feat/log-service
branch
from
18d2738
to
b345526
Compare
ChristiaanScheermeijer
force-pushed
the
feat/log-service
branch
from
b345526
to
35303c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a log service according to the discussion here #121 which can be extended or replaced with custom solutions.
The next step is to add more debug logging (not at once).