-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat / log service #539
Feat / log service #539
Conversation
Visit the preview URL for this PR (updated for commit 35303c8): https://ottwebapp--pr539-feat-log-service-t1xogqkd.web.app (expires Sat, 03 Aug 2024 13:39:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I've kept a sharp eye on the debug levels you've chosen for the existing logs, but I'd agree with all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement!
packages/common/src/services/integrations/cleeng/CleengService.ts
Outdated
Show resolved
Hide resolved
packages/common/src/services/logging/transporters/ConsoleTransporter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
18d2738
to
b345526
Compare
b345526
to
35303c8
Compare
Description
This PR implements a log service according to the discussion here #121 which can be extended or replaced with custom solutions.
The next step is to add more debug logging (not at once).