Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbudzinski/new build #49

Merged
merged 20 commits into from
May 6, 2022
Merged

Dbudzinski/new build #49

merged 20 commits into from
May 6, 2022

Conversation

dbudzins
Copy link
Contributor

@dbudzins dbudzins commented May 2, 2022

Description

To keep sync with partner and industry trends, we want to migrate off of snowpack and to vite. This PR does just that. Most of the changes are small 1-1 migrations (changing the build constant naming, updating the snapshots with the Vite header, updating test helpers from jest to vitest, etc.)

As mentioned above, I also migrated from jest to vitest. Jest doesn't work nicely with the vite build pipeline, and would require workarounds and a secondary test-only build setup, while vitest, though relatively new, works nicely with vite out of the box.

This PR solves #36.

Steps completed:

According to our definition of done, I have completed the following steps:

  • User stories met
  • Storybook stories
  • Unit tests added
  • Linting passing
  • Unit tests passing
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link
Collaborator

@AntonLantukh AntonLantukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I also hope to spend some time today or tomorrow to pull the branch and to test the updated build / dev process.

CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/screens/User/User.test.tsx Outdated Show resolved Hide resolved
src/components/Router/Router.tsx Show resolved Hide resolved
docs/easy-deployments.md Outdated Show resolved Hide resolved
@dbudzins dbudzins requested a review from AntonLantukh May 4, 2022 13:29
Copy link
Collaborator

@AntonLantukh AntonLantukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixes! I also highlighted some issues with dependencies. It seems that we can get rid of async, jake and minimist, c8(?).

src/components/Router/Router.tsx Show resolved Hide resolved
@dbudzins dbudzins merged commit 6fcd9d8 into develop May 6, 2022
@dbudzins dbudzins deleted the dbudzinski/new-build branch May 13, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants