-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbudzinski/new build #49
Conversation
…sion without vulnerability
…ile and desktop results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I also hope to spend some time today or tomorrow to pull the branch and to test the updated build / dev process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixes! I also highlighted some issues with dependencies. It seems that we can get rid of async, jake and minimist, c8(?).
Description
To keep sync with partner and industry trends, we want to migrate off of snowpack and to vite. This PR does just that. Most of the changes are small 1-1 migrations (changing the build constant naming, updating the snapshots with the Vite header, updating test helpers from jest to vitest, etc.)
As mentioned above, I also migrated from jest to vitest. Jest doesn't work nicely with the vite build pipeline, and would require workarounds and a secondary test-only build setup, while vitest, though relatively new, works nicely with vite out of the box.
This PR solves #36.
Steps completed:
According to our definition of done, I have completed the following steps: