Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(project): per media ads #370

Merged
merged 10 commits into from
Nov 8, 2023
Merged

feat(project): per media ads #370

merged 10 commits into from
Nov 8, 2023

Conversation

AntonLantukh
Copy link
Collaborator

Description

  • add per media ads functionality

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@AntonLantukh
feat(project): per media ads
f27283e 
- add per media ads functionality
@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 20a491b):

https://ottwebapp--pr370-feature-add-per-medi-bw8l4ftp.web.app

(expires Fri, 08 Dec 2023 14:09:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@AntonLantukh AntonLantukh force-pushed the feature/add-per-media-ads branch 6 times, most recently from 556f02c to c2e1d66 Compare October 31, 2023 14:07
@AntonLantukh AntonLantukh marked this pull request as ready for review October 31, 2023 14:35
dbudzins
dbudzins approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@dbudzins dbudzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AntonLantukh AntonLantukh merged commit 19592a5 into develop Nov 8, 2023
9 checks passed
@AntonLantukh AntonLantukh deleted the feature/add-per-media-ads branch November 8, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbudzins dbudzins dbudzins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonLantukh @dbudzins