Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): Update React to version 18.2.0 #280

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

MelissaDTH
Copy link
Contributor

@MelissaDTH MelissaDTH commented May 23, 2023

Description

This PR updates React version from 17.0.2 to 18.2.0, the following changes are made:

  • Updated React version to 18.2.0 in package.json and related dependencies (React Changelog)
    • Adds necessary typings throughout the project to align with the updated React version
  • Explicitly declared the children prop in the components that use React.FC type, as the children prop has been removed from React.FC in React 18

Note:
This PR is still in draft since the update to React 18 is not completely compatible with the current TileSlider component. There's an issue with that component when you use the right or left controls, the transition is not smooth. Further work is required to resolve this compatibility issue

@MelissaDTH MelissaDTH marked this pull request as draft May 23, 2023 06:38
@MelissaDTH MelissaDTH changed the base branch from develop to feat/jwp-sprint-2023-2 May 23, 2023 06:38
@github-actions
Copy link

github-actions bot commented May 23, 2023

Visit the preview URL for this PR (updated for commit 6f0add2):

https://ottwebapp--pr280-feat-react-update-jn4u9gjc.web.app

(expires Fri, 01 Sep 2023 17:08:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@RCVZ RCVZ closed this May 30, 2023
@RCVZ RCVZ reopened this Jun 1, 2023
Base automatically changed from feat/jwp-sprint-2023-2 to develop June 5, 2023 07:20
@AntonLantukh AntonLantukh force-pushed the feat/react-update branch 4 times, most recently from e7ec865 to 5488327 Compare July 18, 2023 12:52
@AntonLantukh AntonLantukh changed the title Feat / update React to version 18.2.0 feat(project): Update React to version 18.2.0 Jul 18, 2023
@AntonLantukh AntonLantukh force-pushed the feat/react-update branch 4 times, most recently from 3bd76ce to 598ce7f Compare July 18, 2023 14:27
@AntonLantukh AntonLantukh marked this pull request as ready for review July 24, 2023 11:49
test/testUtils.tsx Outdated Show resolved Hide resolved
@AntonLantukh AntonLantukh merged commit 6216bd2 into develop Aug 3, 2023
10 checks passed
@AntonLantukh AntonLantukh deleted the feat/react-update branch August 3, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants