Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InPlayer register flow #202

Merged
merged 42 commits into from
Dec 14, 2022
Merged

feat: InPlayer register flow #202

merged 42 commits into from
Dec 14, 2022

Conversation

kiremitrov123
Copy link
Collaborator

Description

With this PR, InPlayer register flow is almost completed. It includes changes in pretty much all of the methods that are required for this flow, except the favourites and history. This is what will follow in the next PR.

Updates are mostly in the AccountController.tsx, cleeng.account.service.ts and inplayer.account.service.ts.

No visual changes.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@kiremitrov123 kiremitrov123 added the enhancement New feature or request label Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Visit the preview URL for this PR (updated for commit 13b5e74):

https://ottwebapp--pr202-inplayer-register-09b1boej.web.app

(expires Fri, 13 Jan 2023 11:11:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

types/account.d.ts Outdated Show resolved Hide resolved
types/cleeng.d.ts Outdated Show resolved Hide resolved
@jwplayer jwplayer deleted a comment from kiremitrov123 Dec 8, 2022
@dbudzins dbudzins merged commit 489d8e8 into develop Dec 14, 2022
@dbudzins dbudzins deleted the inplayer/register branch January 8, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants