fix: refactor the condition

jwplayer · Mar 6, 2023 · d69bfed · d69bfed
1 parent 88946a4
commit d69bfed
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/services/inplayer.account.service.ts b/src/services/inplayer.account.service.ts
@@ -278,14 +278,10 @@ export const updatePersonalShelves: UpdatePersonalShelves = async (payload) => {
 
   try {
     history.forEach(async (history) => {
-      if (externalData?.history?.length) {
-        externalData?.history?.forEach(async (historyStore) => {
-          if (historyStore.mediaid === history.mediaid && historyStore.progress !== history.progress) {
-            await InPlayer.Account.updateWatchHistory(history.mediaid, history.progress);
-          }
-        });
-      }
-      if (!currentWatchHistoryIds?.includes(history.mediaid)) {
+      if (
+        !currentWatchHistoryIds?.includes(history.mediaid) ||
+        externalData?.history?.some((e) => e.mediaid == history.mediaid && e.progress != history.progress)
+      ) {
         await InPlayer.Account.updateWatchHistory(history.mediaid, history.progress);
       }
     });