fix: footer overlap fix

jwplayer · Feb 22, 2024 · bf79d10 · bf79d10
1 parent 361c58a
commit bf79d10
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 18 deletions.
diff --git a/packages/ui-react/src/containers/Layout/Layout.module.scss b/packages/ui-react/src/containers/Layout/Layout.module.scss
@@ -1,16 +1,6 @@
 @use '@jwp/ott-ui-react/src/styles/variables';
 @use '@jwp/ott-ui-react/src/styles/theme';
 
-.layout {
-  display: flex;
-  flex-grow: 1;
-  flex-direction: column;
-}
-
-.container {
-  flex: 1;
-}
-
 .footer {
   padding: 20px 40px;
   line-height: 18px;
@@ -63,6 +53,7 @@ div.testFixMargin {
       background-color: variables.$white;
       content: '';
     }
+
     body:global(.is-tabbing) & {
       &:focus {
         &::after {

diff --git a/packages/ui-react/src/containers/Layout/Layout.tsx b/packages/ui-react/src/containers/Layout/Layout.tsx
@@ -144,7 +144,7 @@ const Layout = () => {
   const containerProps = { inert: sideBarOpen ? '' : undefined }; // inert is not yet officially supported in react
 
   return (
-    <div className={styles.layout}>
+    <div>
       <Helmet>
         <title>{siteName}</title>
         <meta name="description" content={metaDescription} />
@@ -153,7 +153,7 @@ const Layout = () => {
         <meta name="twitter:title" content={siteName} />
         <meta name="twitter:description" content={metaDescription} />
       </Helmet>
-      <div className={styles.container} {...containerProps}>
+      <div {...containerProps}>
         <Header
           onMenuButtonClick={() => setSideBarOpen(true)}
           logoSrc={banner}

diff --git a/packages/ui-react/src/containers/Layout/__snapshots__/Layout.test.tsx.snap b/packages/ui-react/src/containers/Layout/__snapshots__/Layout.test.tsx.snap
@@ -2,12 +2,8 @@
 
 exports[`<Layout /> > renders layout 1`] = `
 <div>
-  <div
-    class="_layout_c71437"
-  >
-    <div
-      class="_container_c71437"
-    >
+  <div>
+    <div>
       <header
         class="_header_f4f7a7 _static_f4f7a7"
       >