fix: pr comments

jwplayer · Jul 17, 2023 · 9a98254 · 9a98254
1 parent 372e133
commit 9a98254
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/public/locales/en/user.json b/public/locales/en/user.json
@@ -108,10 +108,11 @@
     "content_rating_helper": "Content 12+ will not be available for kids profiles",
     "create": "Create profile",
     "delete": "Delete profile",
-    "delete_main": "The main profile cannot be deleted.",
     "delete_description": "Permanently delete your profile along with all of your watch history and favorites.",
+    "delete_main": "The main profile cannot be deleted.",
     "description": "Profiles allow you to watch content and assemble your own personal collection of favorites.",
     "greeting": "Howdy",
+    "greeting_with_name": "Howdy, {{name}}",
     "info": "Profile info",
     "kids": "Kids",
     "name": "User name"

diff --git a/public/locales/es/user.json b/public/locales/es/user.json
@@ -109,9 +109,11 @@
     "content_rating_helper": "",
     "create": "",
     "delete": "",
+    "delete_description": "",
     "delete_main": "",
     "description": "",
     "greeting": "",
+    "greeting_with_name": "",
     "info": "",
     "kids": "",
     "name": ""

diff --git a/src/containers/Profiles/EditProfile.tsx b/src/containers/Profiles/EditProfile.tsx
@@ -91,10 +91,7 @@ const EditProfile = ({ contained = false }: EditProfileProps) => {
         <div className={styles.leftColumn}>
           <div className={styles.panel}>
             <div className={profileStyles.avatar}>
-              <h2>
-                {t('profile.greeting')}
-                {`${fullName && ','} ${fullName}`}
-              </h2>
+              <h2>{fullName ? t('profile.greeting_with_name', { fullName }) : t('profile.greeting')}</h2>
               <img src={selectedAvatar || profileDetails?.avatar_url} />
             </div>
           </div>

diff --git a/src/containers/Profiles/Form.tsx b/src/containers/Profiles/Form.tsx
@@ -105,8 +105,8 @@ const Form = ({ initialValues, formHandler, setFullName, selectedAvatar, showCan
           </div>
         </div>
         <>
-          <Button type="submit" label="Save" variant="outlined" disabled={submitting} />
-          {showCancelButton && <Button onClick={() => navigate('/u/profiles')} label="Cancel" variant="text" />}
+          <Button type="submit" label={t('account.save')} variant="outlined" disabled={submitting} />
+          {showCancelButton && <Button onClick={() => navigate('/u/profiles')} label={t('account.cancel')} variant="text" />}
         </>
       </div>
     </form>