feat(project): enableSharing toggled on by default

- remove custom param
jwplayer · Jan 27, 2023 · 6367493 · 6367493
1 parent 2a268ce
commit 6367493
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -160,12 +160,6 @@ You can change the background color of the shelf with the help of this property
 
 ---
 
-**custom.enableSharing** (optional)
-
-Set this parameter to `true` if you want to enable the "Share" button on the video and series detail screen.
-
----
-
 **styling**
 
 Use the `styling` object to define extra styles for your application.

diff --git a/src/pages/ScreenRouting/mediaScreens/MediaMovie/MediaMovie.tsx b/src/pages/ScreenRouting/mediaScreens/MediaMovie/MediaMovie.tsx
@@ -25,7 +25,6 @@ import Button from '#components/Button/Button';
 import type { ScreenComponent } from '#types/screens';
 import useQueryParam from '#src/hooks/useQueryParam';
 import InlinePlayer from '#src/containers/InlinePlayer/InlinePlayer';
-import { isTruthyCustomParamValue } from '#src/utils/common';
 
 const MediaMovie: ScreenComponent<PlaylistItem> = ({ data, isLoading }) => {
   const { t } = useTranslation('video');
@@ -45,7 +44,6 @@ const MediaMovie: ScreenComponent<PlaylistItem> = ({ data, isLoading }) => {
   const { config, accessModel } = useConfigStore(({ config, accessModel }) => ({ config, accessModel }), shallow);
   const { siteName, features, custom } = config;
 
-  const enableSharing: boolean = isTruthyCustomParamValue(custom?.enableSharing);
   const isFavoritesEnabled: boolean = Boolean(features?.favoritesList);
   const inlineLayout = Boolean(custom?.inlinePlayer);
 
@@ -80,7 +78,7 @@ const MediaMovie: ScreenComponent<PlaylistItem> = ({ data, isLoading }) => {
   const canonicalUrl = data ? `${window.location.origin}${mediaURL(data)}` : window.location.href;
 
   const primaryMetadata = formatVideoMetaString(data);
-  const shareButton = enableSharing && <ShareButton title={data.title} description={data.description} url={canonicalUrl} />;
+  const shareButton = <ShareButton title={data.title} description={data.description} url={canonicalUrl} />;
   const startWatchingButton = <StartWatchingButton item={data} playUrl={mediaURL(data, feedId, true)} />;
 
   const favoriteButton = isFavoritesEnabled && <FavoriteButton item={data} />;

diff --git a/src/pages/ScreenRouting/mediaScreens/MediaSeriesEpisode/MediaSeriesEpisode.tsx b/src/pages/ScreenRouting/mediaScreens/MediaSeriesEpisode/MediaSeriesEpisode.tsx
@@ -30,7 +30,6 @@ import type { ScreenComponent } from '#types/screens';
 import useQueryParam from '#src/hooks/useQueryParam';
 import useGetSeriesId from '#src/hooks/useGetSeriesId';
 import Loading from '#src/pages/Loading/Loading';
-import { isTruthyCustomParamValue } from '#src/utils/common';
 
 const MediaSeriesEpisode: ScreenComponent<PlaylistItem> = ({ data }) => {
   const breakpoint = useBreakpoint();
@@ -46,7 +45,6 @@ const MediaSeriesEpisode: ScreenComponent<PlaylistItem> = ({ data }) => {
   // Config
   const { config, accessModel } = useConfigStore(({ config, accessModel }) => ({ config, accessModel }), shallow);
   const { features, siteName, custom } = config;
-  const enableSharing: boolean = isTruthyCustomParamValue(custom?.enableSharing);
   const isFavoritesEnabled: boolean = Boolean(features?.favoritesList);
   const inlineLayout = Boolean(custom?.inlinePlayer);
 
@@ -112,7 +110,7 @@ const MediaSeriesEpisode: ScreenComponent<PlaylistItem> = ({ data }) => {
     episodeItem.episodeNumber
   }/${episodesInSeason}`;
 
-  const shareButton = enableSharing && <ShareButton title={episodeItem.title} description={episodeItem.description} url={canonicalUrl} />;
+  const shareButton = <ShareButton title={episodeItem.title} description={episodeItem.description} url={canonicalUrl} />;
   const startWatchingButton = <StartWatchingButton item={episodeItem} playUrl={episodeURL(episodeItem, seriesId, true, feedId)} />;
 
   const favoriteButton = isFavoritesEnabled && <FavoriteButton item={episodeItem} />;

diff --git a/src/pages/ScreenRouting/playlistScreens/PlaylistLiveChannels/PlaylistLiveChannels.tsx b/src/pages/ScreenRouting/playlistScreens/PlaylistLiveChannels/PlaylistLiveChannels.tsx
@@ -24,16 +24,13 @@ import { generateMovieJSONLD } from '#src/utils/structuredData';
 import type { ScreenComponent } from '#types/screens';
 import type { Playlist } from '#types/playlist';
 import Loading from '#src/pages/Loading/Loading';
-import { isTruthyCustomParamValue } from '#src/utils/common';
 
 const PlaylistLiveChannels: ScreenComponent<Playlist> = ({ data: { feedid, playlist } }) => {
   const { t } = useTranslation('epg');
 
   // Config
   const { config, accessModel } = useConfigStore(({ config, accessModel }) => ({ config, accessModel }), shallow);
-  const { siteName, custom } = config;
-
-  const enableSharing: boolean = isTruthyCustomParamValue(custom?.enableSharing);
+  const { siteName } = config;
 
   // Routing
   const location = useLocation();
@@ -130,10 +127,9 @@ const PlaylistLiveChannels: ScreenComponent<Playlist> = ({ data: { feedid, playl
   const canonicalUrl = `${window.location.origin}${liveChannelsURL(feedid, channel.id)}`;
   const pageTitle = `${channel.title} - ${siteName}`;
 
-  const shareButton =
-    enableSharing && channelMediaItem ? (
-      <ShareButton title={channelMediaItem.title} description={channelMediaItem.description} url={window.location.href} />
-    ) : null;
+  const shareButton = channelMediaItem ? (
+    <ShareButton title={channelMediaItem.title} description={channelMediaItem.description} url={window.location.href} />
+  ) : null;
 
   const startWatchingButton = channelMediaItem ? (
     <>