fix: avoid using auth provider name in components

jwplayer · Jul 13, 2023 · 1a8a70c · 1a8a70c
1 parent 411d0dd
commit 1a8a70c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/src/services/cleeng.account.service.ts b/src/services/cleeng.account.service.ts
@@ -152,7 +152,7 @@ export const getPublisherConsents: GetPublisherConsents = async (config) => {
   const consents = ((response?.responseData?.consents || []) as CleengConsent[]).map(
     (cleengConsent): Consent => ({
       type: REGISTER_FIELD_VARIANT.CHECKBOX,
-      provider: 'cleeng',
+      isCustomRegisterField: false,
       defaultValue: cleengConsent.enabledByDefault,
       name: cleengConsent.name,
       label: cleengConsent.label,

diff --git a/src/services/inplayer.account.service.ts b/src/services/inplayer.account.service.ts
@@ -175,7 +175,7 @@ export const getPublisherConsents: GetPublisherConsents = async (config) => {
       .map(
         (field): Consent => ({
           type: field.type as ConsentFieldVariants,
-          provider: 'jwp',
+          isCustomRegisterField: true,
           defaultValue: field.type === REGISTER_FIELD_VARIANT.CHECKBOX ? field.default_value === 'true' : field.default_value,
           name: field.name,
           label: field.label,
@@ -479,7 +479,7 @@ function getTermsConsent(): Consent {
 
   return {
     type: REGISTER_FIELD_VARIANT.CHECKBOX,
-    provider: 'jwp',
+    isCustomRegisterField: true,
     required: true,
     name: 'terms',
     label: i18next.t('account:registration.terms_consent', { termsUrl }),

diff --git a/src/utils/collection.ts b/src/utils/collection.ts
@@ -76,7 +76,7 @@ const formatConsentValues = (publisherConsents: Consent[] | null = [], customerC
     const consent = customerConsents?.find((customerConsent) => customerConsent.name === publisherConsent.name);
 
     if (consent) {
-      const value = publisherConsent.provider === 'cleeng' ? consent.state === 'accepted' : consent.value ?? '';
+      const value = publisherConsent.isCustomRegisterField ? consent.value ?? '' : consent.state === 'accepted';
       values[publisherConsent.name] = value;
     }
   });

diff --git a/types/account.d.ts b/types/account.d.ts
@@ -218,13 +218,11 @@ export type UpdateCustomerArgs = {
   fullName?: string;
 };
 
-export type ConsentProvider = 'cleeng' | 'jwp';
-
 export type ConsentFieldVariants = 'input' | 'select' | 'country' | 'us_state' | 'radio' | 'checkbox' | 'datepicker';
 
 export interface Consent {
   type: ConsentFieldVariantss;
-  provider: ConsentProvider;
+  isCustomRegisterField: boolean;
   defaultValue: string | boolean;
   name: string;
   label: string;