[WIP] return promise from DataService.list #62

jwforres · 2016-04-21T22:25:13Z

No description provided.

…stry - Add angular-extension-registry - TODO: register openshift/angular-extension-registry w/bower & update - Update hawtio javalink extension to new manager - Update online-extensions - Swap java console link icon to fa-share - Update extensions nav-system-status, nav-system-status-mobile, nav-user-dropdown - eliminate documtentation & about link html, register as extension in run block - Move logout link into extension - Style adjustments to needed to position utility nav links

- rename openshiftConsoleExtensions to javaLinkExtension to encourage individual module naming - add /extensions/javalink directory to help encourage extension organization - add hawtioPluginLoader.addModule() back to load module after openshiftConsole bootstraps - fix missing containerStatus check - wrap in IIFE to protect against globals

Use function declarations rather than function expressions when a function is called before defined. This can prevent runtime errors. (The newer jshint is catching these problems.)

URI.expand() returns a URI instance rather than a string, which causes later errors passing query parameters in the $http config object. https://medialize.github.io/URI.js/docs.html#static-expand

`pod-count` class is no longer used in donut title.

Fix UI e2e test failure

Add network metrics to pod page on console

Warn users when navigating away with the terminal window open

Fix httpGet path in pod template

Fix usage rate calculation for network metrics in pod page

Update humanizeKind filter to use lowercase by default

Confirm project delete by typing project name

Edit routes in web console

Changing copy to clipboard button to an input + button

API discovery in the console

…ff in your project

Other resources page

Enabling WebHooks from console will add Generic webhook

Web console support for JenkinsPipeline builds

jwforres · 2016-04-21T22:27:34Z

@spadgett @liggitt first pass, just using the promise in the other resources page for the moment, but if folks are happy with the general idea then i can update the other places we are using list

jwforres · 2016-04-21T22:27:45Z

cc @benjaminapetersen

benjaminapetersen · 2016-04-22T13:39:10Z

assets/app/scripts/services/data.js

+
+    var deferred = $q.defer();
+    var promises = this._listPromises(resource, context);
+    promises.push(deferred);



How do you feel about hiding away some of the details here to make the flow a little easier:

var key = this._uniqueKeyForResourceContext(resource, context); // currently we are inferring 'cached' from _watchInFlight and _resourceVersion if(this.cached(key)) { this.fireCallbacks(this._data(key)); deferred.resolve(this._data(key)); }

agree its more readable but thats a significantly bigger refactor across this file to change all those method signatures to one param instead of two, to me its not worth the added regression risk, but I'm open to other opinions @spadgett @liggitt

i'd be ok with just adding a cached(resource, context) that does the checks for watchInFlight and resourceVersion, i think that is your biggest concern right? that its not obvious what watchInFlight && resourceVersion is actually checking.

Yeah, just making DataService as friendly as possible since its the brains behind everything. I'm good with ignoring that for later, Ill make a mental note and may PR it as a tech debt thing down the road.

jwforres · 2016-04-25T23:34:49Z

pushed some updates

benjaminapetersen · 2016-04-26T16:38:47Z

Cool, looks good!

benjaminapetersen · 2016-04-27T15:14:55Z

Commenting about the watch/promise deal because I agree its worth tinkering a bit. Would be nice to update .watch() to look more like .get(), etc:

DataService
  .get('stuff')
  .then(function(data) {
    // yay
  }, function() {
    // boo :(
  });

DataService
  .watch('stuff')
  .event(function(evt) {
    // yay
  }, function(error) {
    // boo :(
  });

.event() seems meaningful in websocket lingo, dunno if anyone else has thoughts. The trick is just ensuring that .event() has a queue internally (like a promise) rather than just accepting a single callback.

Prob is worth investigating as a separate PR as well, though.

UPDATE: the streamer is sort of a facade for a promise as well:

DataService
  .createStream('foo')
  .onMessage(function() {
    // yay
  })
  // uh oh, deviant!
  .onError(function() {})

spadgett and others added 30 commits April 8, 2016 12:56

Remove angular-patternfly utilization card dependency

2ac67e9

Updating PatternFly and Angular-PatternFly to v3.3.0

f35e2af

Update Patternfly utilization chart class name

75086aa

Use @dl-horizontal-breakpoint

1cf8c34

Improving pod-template visualization

4bac01d

Don't enable editor save button until after a change

d10402b

Support autoscaling in the web console

ffea0c5

Update online extensions, avoid rendering emtpy DOM nodes

a714913

Web console support for health checks

354e88e

Fix failing web console unit tests

dbe6592

Update grunt-contrib-jshintrc to 1.0.0

1678bf4

Fix jshint warnings

ce7e23f

Use function declarations rather than function expressions when a function is called before defined. This can prevent runtime errors. (The newer jshint is catching these problems.)

DataService._urlForResource should return a string

93b422a

URI.expand() returns a URI instance rather than a string, which causes later errors passing query parameters in the $http config object. https://medialize.github.io/URI.js/docs.html#static-expand

Left align tabs when they wrap to second line

c64ebe6

Exclude google-code-prettify

5fa8dcd

Web console: debug terminal for crashing pods

799654f

Add container entrypoint to debug dialog

5b90bf3

Add _spacers.less to generate pad/mar utility classes

f4fe6f9

Fix UI e2e test failure

e0a99d5

`pod-count` class is no longer used in donut title.

Merge pull request #41 from spadgett/fix-ui-e2e-tests

bbd0039

Fix UI e2e test failure

Add network metrics to pod page on console

67256aa

Merge pull request #39 from fabianofranz/602_network_metrics_on_pod_page

c4a01d4

Add network metrics to pod page on console

Warn users when navigating away with the terminal window open

7780d61

Merge pull request #42 from spadgett/debug-pod-nav-warning

dd59b2d

Warn users when navigating away with the terminal window open

Fix httpGet path in pod template

ecdd5c5

Merge pull request #46 from spadgett/health-check-path

7217406

Fix httpGet path in pod template

Fix usage rate calculation for network metrics in pod page

79aa657

Merge pull request #47 from fabianofranz/issues_8470

4d9b27d

Fix usage rate calculation for network metrics in pod page

jwforres and others added 16 commits April 19, 2016 15:38

API discovery in the console

af84031

Edit routes in web console

8d94dd4

Update humanizeKind filter to use lowercase by default

11bef29

Confirm project delete by typing project name

6e6af7a

Merge pull request #60 from spadgett/humanize-kind-case

81b9709

Update humanizeKind filter to use lowercase by default

Merge pull request #59 from spadgett/confirm-delete-project

9d91879

Confirm project delete by typing project name

Merge pull request #57 from spadgett/edit-routes

0a21566

Edit routes in web console

Changing copy to clipboard button to an input + button

c9ff25f

Merge pull request #50 from rhamilto/copy-button-addon

2afa740

Changing copy to clipboard button to an input + button

Merge pull request #38 from jwforres/api_discovery

82aea92

API discovery in the console

Add an 'Other resources' page to view, raw edit, and delete other stu…

2c01c03

…ff in your project

Merge pull request #56 from jwforres/other_resources

364e88f

Other resources page

Enabling WebHooks from console will add Generic webhook

cbe58bf

Merge pull request #55 from jhadvig/generate_generic

d49350a

Enabling WebHooks from console will add Generic webhook

Web console support for JenkinsPipeline builds

65ecc64

Merge pull request #54 from spadgett/jenkins-pipeline-strategy

cb6a5f9

Web console support for JenkinsPipeline builds

benjaminapetersen reviewed Apr 22, 2016
View reviewed changes

[wip] return promise from DataService.list

bbc376c

jwforres force-pushed the list_promises branch from c167400 to bbc376c Compare April 25, 2016 23:33

jwforres force-pushed the console_1.3 branch 2 times, most recently from 145b910 to 536125d Compare April 27, 2016 00:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] return promise from DataService.list #62

[WIP] return promise from DataService.list #62

jwforres commented Apr 21, 2016

jwforres commented Apr 21, 2016

jwforres commented Apr 21, 2016 •

edited

Loading

benjaminapetersen Apr 22, 2016

jwforres Apr 25, 2016

benjaminapetersen Apr 26, 2016

jwforres commented Apr 25, 2016

benjaminapetersen commented Apr 26, 2016

benjaminapetersen commented Apr 27, 2016 •

edited

Loading

[WIP] return promise from DataService.list #62

Are you sure you want to change the base?

[WIP] return promise from DataService.list #62

Conversation

jwforres commented Apr 21, 2016

jwforres commented Apr 21, 2016

jwforres commented Apr 21, 2016 • edited Loading

benjaminapetersen Apr 22, 2016

Choose a reason for hiding this comment

jwforres Apr 25, 2016

Choose a reason for hiding this comment

benjaminapetersen Apr 26, 2016

Choose a reason for hiding this comment

jwforres commented Apr 25, 2016

benjaminapetersen commented Apr 26, 2016

benjaminapetersen commented Apr 27, 2016 • edited Loading

jwforres commented Apr 21, 2016 •

edited

Loading

benjaminapetersen commented Apr 27, 2016 •

edited

Loading