Skip to content

fix(runtime): array of vnode could not be patched #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2023
Merged

fix(runtime): array of vnode could not be patched #27

merged 4 commits into from
Jan 30, 2023

Conversation

@wibus-wee
Copy link
Member

@wibus-wee wibus-wee commented Jan 30, 2023

fixed #26

@wibus-wee wibus-wee marked this pull request as draft January 30, 2023 04:12
@wibus-wee
Copy link
Member Author

wibus-wee commented Jan 30, 2023

I marked isNew as ture for the new element in VNode[] (diffRecursive()).

But in updateDOM(), isNew turn to false again

wibus-wee
wibus-wee commented Jan 30, 2023
View reviewed changes
@wibus-wee wibus-wee requested a review from AkaraChen January 30, 2023 05:31
@wibus-wee wibus-wee marked this pull request as ready for review January 30, 2023 05:32
@wibus-wee wibus-wee merged commit 1b64a40 into main Jan 30, 2023
@wibus-wee wibus-wee deleted the fix/array-vnode-re-render-bug branch January 30, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkaraChen AkaraChen AkaraChen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing components when re-rendering with data change

3 participants

@wibus-wee @AkaraChen