Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more descriptive links. #9

Merged
merged 2 commits into from
Oct 6, 2016
Merged

Adding more descriptive links. #9

merged 2 commits into from
Oct 6, 2016

Conversation

Carmezim
Copy link
Contributor

@Carmezim Carmezim commented Oct 6, 2016

Improving readability and making a cleaner template.
If you agree with the changes I can follow finishing the file.

Improving readability and making a cleaner template.
If you agree with the changes I can follow finishing the file.
@jwasham jwasham merged commit 4f00937 into jwasham:master Oct 6, 2016
@jwasham
Copy link
Owner

jwasham commented Oct 6, 2016

This looks great! Thanks!
For the videos (Youtube, Coursera, etc), would you mind adding (video) to the descriptions?

@Carmezim
Copy link
Contributor Author

Carmezim commented Oct 6, 2016

Thank you for putting all this together and making it available!
Sure. I had updated up to L540 though and lost the commit for some reason. I think you were just merging while I was finishing the editing so it did not get the commit =/. I will redo afterwards and add the (video).

The file is huge so is it alright if I keep the updates in chunks?
I will try to have it finished tomorrow though.

@jwasham
Copy link
Owner

jwasham commented Oct 6, 2016

Ouch! Lost commits!
Feel free to do so in chunks.
This will really help the readability. This started as just a personal to-do list that got out of hand.

@Carmezim
Copy link
Contributor Author

Carmezim commented Oct 6, 2016

No worries, I recovered it also (phew).
Nice, I will be finishing it at last by tomorrow and committing as I advance then ping you when complete.
I now removed to the next commit two coursera links, this and the one below at the compilers topic due to being deprecated. They are still on the actual file so you can check it if you want.
This is amazing and thank you once again for building it and publicly sharing!

And btw, I wish you all success on your endeavor!

@jwasham
Copy link
Owner

jwasham commented Oct 6, 2016

I've been wanting to remove the Coursera and Lynda.com (all courses) links because the links don't work when classes are not in session. If you can find related Youtube videos, please replace them with Youtube videos.

jwasham pushed a commit that referenced this pull request Oct 11, 2016
 更正部分关键词的翻译
jwasham pushed a commit that referenced this pull request Oct 11, 2017
jwasham pushed a commit that referenced this pull request Oct 11, 2017
jwasham pushed a commit that referenced this pull request Nov 28, 2020
Add translation of system design section
codecalligrapher pushed a commit to codecalligrapher/coding-interview-university that referenced this pull request Jun 23, 2021
Add translation of system design section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants