Remove nonportable GNU code #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
|
@normanmaurer it would be nice if someone rebased it to make the build pass |
It's not just __APPLE__ that doesn't support this, but POSIX as a whole. This doesn't seem necessary at all so I just removed it.
Contributor
Author
|
Rebased. |
Member
|
Thanks for the contribution! |
Member
|
👍 no good reason to keep those. |
Contributor
|
Thanks a lot 🎉👌
… Am 31.01.2018 um 16:52 schrieb Johannes Rudolph ***@***.***>:
👍 no good reason to keep those.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not just __APPLE__ that doesn't support this, but POSIX as a whole.
This doesn't seem necessary at all so I just removed it.