Skip to content

Changed function conversion to use name, added Symbolics.Differential #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Changed function conversion to use name, added Symbolics.Differential #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf42040
Changed function conversion to use name
jClugstor Sep 7, 2023
1910676
Changed it to use pygetattr for function and name
jClugstor Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/SymPyPythonCallSymbolicsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function pyconvert_rule_sympy_derivative(::Type{Symbolics.Num}, x)
return PythonCall.pyconvert_unconverted()
end
variables = pyconvert.(Symbolics.Num,x.variables)
derivatives = prod(var -> Differential(var), variables)
derivatives = prod(var -> Symbolics.Differential(var), variables)
expr = pyconvert(Symbolics.Num, x.expr)
return PythonCall.pyconvert_return(derivatives(expr))
end
Expand All @@ -60,7 +60,7 @@ function pyconvert_rule_sympy_function(::Type{Symbolics.Num}, x)
if !pyisinstance(x,sp.Function)
return PythonCall.pyconvert_unconverted()
end
nm = PythonCall.pygetattr(x, "func", nothing)
nm = PythonCall.pygetattr(PythonCall.pygetattr(x, "func", nothing),"name",nothing)
isnothing(nm) && return PythonCall.pyconvert_unconverted() # XXX
name = pyconvert(Symbol, nm)
args = pyconvert.(Symbolics.Num, x.args)
Expand Down