Skip to content

Typo - Update README.md #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2023
Merged

Typo - Update README.md #20

merged 2 commits into from
Aug 31, 2023

Conversation

@PallHaraldsson
Copy link
Contributor

[skip ci]

@PallHaraldsson
Copy link
Contributor Author

Before merging. About "@vars would be deprecated" should that be "is" or will"? I could add the correct change for that to this PR, or not. Also I noticed "newdefault" that I had missed, and it should be two words, right...

@jverzani
Copy link
Owner

Thanks! I just had fixed this in #19. But if you had other suggestions, let me know. I'm quite happy to get them,

@PallHaraldsson
Copy link
Contributor Author

You mean "@vars of SymPy is not provided; use the more powerful @syms macro only", I can add change to that in the README and fix the other thing, then merge would you want that?

@jverzani
Copy link
Owner

That would be great. Thanks!

jverzani
jverzani reviewed Aug 31, 2023
View reviewed changes
Copy link
Owner

@jverzani jverzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@jverzani jverzani merged commit d122eeb into jverzani:main Aug 31, 2023
@PallHaraldsson PallHaraldsson deleted the patch-1 branch August 31, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jverzani jverzani jverzani left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PallHaraldsson @jverzani