Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Reactive.jl #5

Closed
timholy opened this issue Nov 16, 2015 · 10 comments
Closed

The new Reactive.jl #5

timholy opened this issue Nov 16, 2015 · 10 comments

Comments

@timholy
Copy link
Contributor

timholy commented Nov 16, 2015

JuliaGizmos/Reactive.jl#65 was a big (and likely breaking) change that just got merged. Once it gets tagged (CC @shashi), this will likely need updating. I might be able to help, but first some questions:

  • Are you interested in registering this sometime? If so, I might use it in GtkUtilities.jl.
  • Given the existence of Immerse.jl, what do you think of removing the Winston dependency? I went with Gadfly mostly because it is more actively maintained.
@jverzani
Copy link
Owner

Thanks for the heads up Tim. I'll see if I can do the updates. Hopefully it is straightforward. Once done, let's talk about if it makes sense to merge into GtkUtilities. I'd be all for that if it made sense to you. As for Winston, absolutely. I had it only because I couldn't get Gadfly to render quickly enough -- but you did that hard work. I'll ping you when I get this done, hopefully this week.

@timholy
Copy link
Contributor Author

timholy commented Nov 16, 2015

To be clear, I wasn't suggesting merging it in; the symmetry with regards to Interact.jl suggests leaving this a standalone package. I was more thinking about using it in GtkUtilities.

Depending on my schedule, I may be able to help with the work, though obviously great if you can do it.

If you're not already aware of it, one thing I'd like to call your attention to: JuliaGraphics/Gtk.jl#161 (similarly JuliaGraphics/Gtk.jl#167), and see workarounds in places like this. See also the new @guarded macro for callbacks to keep from tanking Gtk when a callback function has an error. Most comprehensive docs on all this are here.

@timholy
Copy link
Contributor Author

timholy commented Nov 16, 2015

Gadfly is still a bit slow for the first plot, but the precompile directives help a lot. I'm also contemplating providing support for the userimg.jl solution, which should make the latency-to-first-plot nearly zero.

@shashi
Copy link
Contributor

shashi commented Nov 16, 2015

You should be good to go if you follow the deprecation warnings given by Reactive master. Although this one: WARNING: Reactive.Input is deprecated, use Reactive.Node instead should have been WARNING: Reactive.Input is deprecated, use Reactive.Signal instead. Signal is exported and is a typealias to Node, which is not exported. ;)

@jverzani
Copy link
Owner

Thanks Tim, I'll have a look a those links to the Gtk issues. I haven't followed the development there for a while. I'll see how far I get before bothering you with questions. I know you are super busy.

@jverzani
Copy link
Owner

Hi @shahsi. Quick question. In the master version of Interact, I see: abstract Widget <: SignalSource which gives an error as there is no SignalSource abstract type to be found. I think this was in Reactive, but has been renamed. Is there a newer version of Interact I should be using, besides master from https://github.com/JuliaLang/Interact.jl ?

@shashi
Copy link
Contributor

shashi commented Nov 17, 2015

Yeah SignalSource is removed.

I have made these changes to interact but unable to test it (due to an
issue with my IJulia). Will try harder to test and ping you once I have a
working version. Sorry I didn't think of this before encouraging you to
work on this issue !

On Tue, Nov 17, 2015, 6:19 PM john verzani notifications@github.com wrote:

Hi @shahsi. Quick question. In the master version of Interact, I see: abstract
Widget <: SignalSource which gives an error as there is no SignalSource
abstract type to be found. I think this was in Reactive, but has been
renamed. Is there a newer version of Interact I should be using, besides
master from https://github.com/JuliaLang/Interact.jl ?


Reply to this email directly or view it on GitHub
#5 (comment)
.

@jverzani
Copy link
Owner

Could your changes be pushed to a different branch? Then I could test
things out which you patch up your ijulia.

On Tue, Nov 17, 2015 at 8:07 AM, Shashi Gowda notifications@github.com
wrote:

Yeah SignalSource is removed.

I have made these changes to interact but unable to test it (due to an
issue with my IJulia). Will try harder to test and ping you once I have a
working version. Sorry I didn't think of this before encouraging you to
work on this issue !

On Tue, Nov 17, 2015, 6:19 PM john verzani notifications@github.com
wrote:

Hi @shahsi. Quick question. In the master version of Interact, I see:
abstract
Widget <: SignalSource which gives an error as there is no SignalSource
abstract type to be found. I think this was in Reactive, but has been
renamed. Is there a newer version of Interact I should be using, besides
master from https://github.com/JuliaLang/Interact.jl ?


Reply to this email directly or view it on GitHub
<
#5 (comment)

.


Reply to this email directly or view it on GitHub
#5 (comment)
.

John Verzani
Chair, Department of Mathematics
College of Staten Island, CUNY
verzani@math.csi.cuny.edu

@timholy
Copy link
Contributor Author

timholy commented Nov 22, 2015

Really nice work!

I'm going to start playing with this as a foundation for the new ImageView. I am probably going to try to avoid needing any plotting package in ImageView, so the dependency on Plots could be a little weird, but AFAICT that's decoupled from actually loading a plotting package. So I doubt it will cause trouble.

@timholy timholy closed this as completed Nov 22, 2015
@jverzani
Copy link
Owner

I realize the Plots dependency it totally optional, so it is now removed. I'm waiting on a clarification on how the new Reactive and Interact play together, and once that is cleared up will add this to METADATA. Thanks for the encouragement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants