fix unbound type parameters (#12)

I didn't check, but unbound type parameters can be serious performance bugs. Found with JuliaLang/julia#46608
jverzani · Dec 14, 2022 · 5b12cd4 · 5b12cd4
1 parent 472ed45
commit 5b12cd4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/diagonal-block.jl b/src/diagonal-block.jl
@@ -42,7 +42,7 @@ end
 
 ## For twisted we use thee approximate diagonal block
 ## this is exact when the the j-1 and  k+1  rotators are deflated or j=1 or k=end
-function approx_diagonal_block!(A, QF, RF, j, k) where {T, S}
+function approx_diagonal_block!(A, QF, RF, j, k)
     R = RF
     D = QF.D
     Q = QF.Q

diff --git a/src/twisted.jl b/src/twisted.jl
@@ -153,7 +153,7 @@ end
 ##
 ## Implement thee different steps for one pass of the bulge chasing algorithm
 
-function step_0!(m,  ps, psd, Ms::TwistedChain, Des, Asc, D, RF) where {T}
+function step_0!(m,  ps, psd, Ms::TwistedChain, Des, Asc, D, RF)
 
     has_limb = ifelse(m > 1, true, false)
 
@@ -209,7 +209,7 @@ function step_0!(m,  ps, psd, Ms::TwistedChain, Des, Asc, D, RF) where {T}
 end
 
 
-function step_k!(k, n, m, psd, limb_side, limb, Des, Asc, Ms, D, RF) where {T}
+function step_k!(k, n, m, psd, limb_side, limb, Des, Asc, Ms, D, RF)
 
     phatk = psd[k]
 
@@ -300,7 +300,7 @@ function step_k!(k, n, m, psd, limb_side, limb, Des, Asc, Ms, D, RF) where {T}
 end
 
 ## steps k=n-m to  n-2
-function step_knit!(n, m, psd, limb_side, limb, Des,  Asc, Ms, D, RF) where {T}
+function step_knit!(n, m, psd, limb_side, limb, Des,  Asc, Ms, D, RF)
 
     # make bottom
     U = pop!(Des)